Create constant WikiSite for Commons and Wikidata. #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharvaniharan
added a commit
that referenced
this pull request
Apr 6, 2022
* main: (23 commits) Fix updating of reading lists after renaming. (#3251) Update kotlin-gradle-plugin version to 1.6.20 (#3250) Fix: update talk page pageTitle after changing the language (#3241) Refactor title functions (#3232) Disable flaky test of EventPlatformClient. (#3249) Prevent possible crash when highlighting text for editing. (#3248) Bump version code (#3247) Article clicks and Edit history analytics wiring (#3234) Change affects to affect (incorrect plural) (#3242) Fix improper scrolling/jumping when composing long Talk message. (#3245) Fix behavior of article overflow menu in split-screen mode. (#3244) Improve OOP logic for analytics events containing state information. (#3240) Localisation updates from https://translatewiki.net. Convert EventPlatformClient to kotlin. (#3239) Localisation updates from https://translatewiki.net. Get the updated value of duration in timed events. (#3237) Add DAO method to get multiple reading lists. (#3224) Fix deserialization of pageId. (#3236) Further optimize API calls to Commons and Wikidata. (#3227) Create constant WikiSite for Commons and Wikidata. (#3230) ... # Conflicts: # app/src/main/res/layout/view_page_action_overflow.xml
sharvaniharan
added a commit
that referenced
this pull request
Apr 6, 2022
* main: (39 commits) Fix updating of reading lists after renaming. (#3251) Update kotlin-gradle-plugin version to 1.6.20 (#3250) Fix: update talk page pageTitle after changing the language (#3241) Refactor title functions (#3232) Disable flaky test of EventPlatformClient. (#3249) Prevent possible crash when highlighting text for editing. (#3248) Bump version code (#3247) Article clicks and Edit history analytics wiring (#3234) Change affects to affect (incorrect plural) (#3242) Fix improper scrolling/jumping when composing long Talk message. (#3245) Fix behavior of article overflow menu in split-screen mode. (#3244) Improve OOP logic for analytics events containing state information. (#3240) Localisation updates from https://translatewiki.net. Convert EventPlatformClient to kotlin. (#3239) Localisation updates from https://translatewiki.net. Get the updated value of duration in timed events. (#3237) Add DAO method to get multiple reading lists. (#3224) Fix deserialization of pageId. (#3236) Further optimize API calls to Commons and Wikidata. (#3227) Create constant WikiSite for Commons and Wikidata. (#3230) ... # Conflicts: # app/src/main/java/org/wikipedia/page/PageActivity.kt # app/src/main/java/org/wikipedia/views/PageActionOverflowView.kt # app/src/main/res/layout/view_page_action_overflow.xml # app/src/main/res/values-qq/strings.xml
sharvaniharan
added a commit
that referenced
this pull request
Apr 6, 2022
* pageToolbarT302397_design: (39 commits) Fix updating of reading lists after renaming. (#3251) Update kotlin-gradle-plugin version to 1.6.20 (#3250) Fix: update talk page pageTitle after changing the language (#3241) Refactor title functions (#3232) Disable flaky test of EventPlatformClient. (#3249) Prevent possible crash when highlighting text for editing. (#3248) Bump version code (#3247) Article clicks and Edit history analytics wiring (#3234) Change affects to affect (incorrect plural) (#3242) Fix improper scrolling/jumping when composing long Talk message. (#3245) Fix behavior of article overflow menu in split-screen mode. (#3244) Improve OOP logic for analytics events containing state information. (#3240) Localisation updates from https://translatewiki.net. Convert EventPlatformClient to kotlin. (#3239) Localisation updates from https://translatewiki.net. Get the updated value of duration in timed events. (#3237) Add DAO method to get multiple reading lists. (#3224) Fix deserialization of pageId. (#3236) Further optimize API calls to Commons and Wikidata. (#3227) Create constant WikiSite for Commons and Wikidata. (#3230) ... # Conflicts: # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-ja/strings.xml # app/src/main/res/values-qq/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a ton of places where we create new instances of
WikiSiteobjects for Commons and Wikidata, when in fact these objects only need to be created once. The instantiation ofWikiSiteis actually a bit heavy, with text parsing and additional logic, so this is an optimization that could add up performance-wise.