Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct user and article talk pages #3267

Merged
merged 119 commits into from
May 31, 2022
Merged

Distinct user and article talk pages #3267

merged 119 commits into from
May 31, 2022

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Apr 15, 2022

@cooltey cooltey added the WIP Work in progress label Apr 15, 2022
Copy link
Member

@dbrant dbrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if you're still working out the fundamentals, but I thought I'd throw in some initial comments.

@sharvaniharan
Copy link
Collaborator

@cooltey @dbrant Please remember to wire-in the analytics before merging this - refer to this task for details https://phabricator.wikimedia.org/T303519#7885818

@sharvaniharan
Copy link
Collaborator

grey

I was just trying to update the talk page spreadsheet and realized that the grey is not very distinct on dark mode... may be a lighter color group ?

@cooltey
Copy link
Collaborator Author

cooltey commented May 23, 2022

grey

I was just trying to update the talk page spreadsheet and realized that the grey is not very distinct on dark mode... may be a lighter color group ?

I have followed the previous read/unread color group in the class, but I'll double-check with Robin to see if they are the correct colors.

app/src/main/java/org/wikipedia/page/PageTitle.kt Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/talk/TalkTopicHolder.kt Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
cooltey and others added 7 commits May 26, 2022 12:48
…ndroid-wikipedia into talk-page-update-design
)

* Initial commit of adding find-in-page function

* Add find-in-page provider

* Remove provider

* Add searchcallbasck

* Update adapter correctly

* Add highlighting to views

* Add find in page from previous search

* Design review updates

Co-authored-by: Dmitry Brant <dbrant@wikimedia.org>
@dbrant dbrant merged commit d901c91 into main May 31, 2022
@dbrant dbrant deleted the talk-page-update-design branch May 31, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants