Add archived talk pages access in the app #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-android-wikipedia into archived-talk-pages-design
…s-android-wikipedia into archived-talk-pages-design
tacsipacsi
reviewed
Jul 8, 2022
| "&inprop=varianttitles" + | ||
| "&srwhat=text&srinfo=suggestion&srprop=&sroffset=0&srlimit=1" | ||
| ) | ||
| suspend fun searchSubPages(@Query("gpssearch") searchTerm: String?, |
There was a problem hiding this comment.
A trailing slash is missing. For example, https://de.wikipedia.org/w/api.php?action=query&list=prefixsearch&pssearch=Diskussion:Gl%C3%A4ubiger returns Diskussion:Gläubigerschutz as well, even though it’s definitely not an archive of Diskussion:Gläubiger. https://de.wikipedia.org/w/api.php?action=query&list=prefixsearch&pssearch=Diskussion:Gl%C3%A4ubiger/ returns the expected result (nothing, as the given talk page has no archives).
| @@ -90,6 +90,7 @@ | |||
| <string name="menu_page_new_tab">New tab</string> | |||
| <string name="menu_page_reading_lists">Reading lists</string> | |||
| <string name="menu_page_recently_viewed">Recently viewed</string> | |||
| <string name="menu_page_archive">Archive</string> | |||
There was a problem hiding this comment.
Why singular? There may be several archive pages, and for this reason it’s usually in plural (cf. Template:Archives on enwiki).
| @@ -1196,6 +1197,7 @@ | |||
| <string name="talk_footer_view_user_page">View user page</string> | |||
| <string name="talk_footer_view_article">View article</string> | |||
| <string name="talk_footer_last_modified"><![CDATA[Last edited %1$s by %2$s]]></string> | |||
| <string name="talk_archived_title">Talk archive: %s</string> | |||
There was a problem hiding this comment.
This should also be plural, as it lists the several archives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T275917