Fix/improve tracking of latency on page loads. #3773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using
System.currentTimeMillis()
for tracking the latency of page loads, which is actually not the appropriate thing to use in this case.The
currentTimeMillis()
function gives us the "current time" of the device, which can actually change at any moment:A much more appropriate function for measuring an "elapsed" time is the
nanoTime()
function, which gives the total nanoseconds of uptime for the current VM.(Note that we should not be changing all instances of
currentTimeMillis()
intonanoTime()
, since there are cases wherecurrentTimeMillis()
is more appropriate.)