Underpinnings/preludes/fixes to proper insertion of images. #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[note that this PR merges onto another open PR]
This makes a number of enhancements, preparations, and fixes to our current workflow of adding images in the Editing activity.
The biggest flaw in our current way of inserting images: it's not localized!
Meaning, we currently insert a template that looks like this:
[[File:<filename>|thumb|alt=<alt text>|<caption>]]This is technically ok, but we use the same template for all language wikis, whereas the
File:namespace and thethumbandalt=magic words should be localized to the target language, but they're not.This PR adds API functionality that fetches a list of magic words from the target wiki, so that this template can be properly localized. This also makes the resulting template a bit more flexible by excluding parameters that are defaults.