Places (feature branch). #4182
Merged
Places (feature branch). #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Localisation updates from https://translatewiki.net. (#4422)
* Add new lang button to places * Unused import * Remove background from langCodeView * Add long press toast
cooltey
reviewed
Jan 30, 2024
Co-authored-by: Sharvani Haran <sharvaniharan83@gmail.com>
* Places: Tooltips for discoverability * Changes tooltip order * Removed watchlist tooltip from both article screen and main screen * Lint fix * Design tweaks * Show main tooltip on second launch * Remove line-break in tooltip --------- Co-authored-by: Sharvani Haran <sharvaniharan83@gmail.com>
* Initial commit * Fix strings * Added one time show logic * Minor update * update survey dialogs * Minor change * Code review comments addressed -1 * Addressed CR comments and Design Review suggestion * Design review comments addressed * Remove unnecesary line space * Build fix * Update survey conditions * Code review comment addressed * Code review comments addressed --------- Co-authored-by: Sharvani Haran <sharvaniharan83@gmail.com>
* Places event created and Search, mapview and entry points data wired * Minor change * Places: Tooltips for discoverability * Changes tooltip order * Initial commit * Fix strings * Added one time show logic * Minor update * update survey dialogs * Minor change * Code review comments addressed -1 * Addressed CR comments and Design Review suggestion * Design review comments addressed * Remove unnecesary line space * Removed watchlist tooltip from both article screen and main screen * Lint fix * Build fix * Design tweaks * Lint fix * Add tooltip wiring * Update survey conditions * Updated list view and preview dialog wiring * Complete data wiring * Data review comments updated * Code review comment addressed * Codereview comments addressed * stream wiring update --------- Co-authored-by: Sharvani Haran <sharvaniharan83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T347201