New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tab and language icon style for long text #4429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it looks correct on my device (Galaxsy S9, Android 10):
Can we please push back on Designers very strongly when something cannot be done a certain way? Fonts across various devices are not guaranteed to be exactly the same pixel width; we cannot guarantee that a box with an exact pixel size will contain a specific number of characters, because Fonts are not measured the same way that Views are. This is why font sizes are specified in sp
units, while views are specified in dp
units.
We're also forgetting that the user is able to control the global font size adjustment throughout the whole system (many users select a "larger" font size), which makes pixel-defined Views look even worse: Therefore it's generally not a good idea to define the size of a View in precise dp values, when expecting it to contain a specific number of characters. These kinds of Views should be variable size (perhaps with a minimum size) and scalable based on the font. |
Thanks @dbrant I posted a reply to the designer to the ticket: https://phabricator.wikimedia.org/T353562#9508461 and I also tried to apply |
@dbrant it's ready for review! |
https://phabricator.wikimedia.org/T354522#9501302