Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to template flow. #4546

Merged
merged 10 commits into from Mar 25, 2024
Merged

Follow-up to template flow. #4546

merged 10 commits into from Mar 25, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Mar 22, 2024

This fixes an important thing:
When a template does not have TemplateData, we should still show the parameters of the template. This fixes the deserialization logic so that the parameters are shown correctly.

https://phabricator.wikimedia.org/T355141

@dbrant dbrant added the Minor Minor stuff label Mar 22, 2024
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cooltey
Copy link
Collaborator

cooltey commented Mar 22, 2024

(and I think we'll need to update the search result manually by searching if there are any title matches locally and shifting it to the top of the list), I can create a PR for it.
Context: search "Help me" in enwiki.

@dbrant
Copy link
Member Author

dbrant commented Mar 22, 2024

@cooltey cooltey merged commit 4b9c173 into main Mar 25, 2024
1 check passed
@cooltey cooltey deleted the templatesFollowup branch March 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor stuff
2 participants