New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up to template flow. #4546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the Template: Help me
and see if the changes work properly?
(and I think we'll need to update the search result manually by searching if there are any title matches locally and shifting it to the top of the list), I can create a PR for it. |
@cooltey whoops, fixed! (made a typo) |
This fixes an important thing:
When a template does not have TemplateData, we should still show the parameters of the template. This fixes the deserialization logic so that the parameters are shown correctly.
https://phabricator.wikimedia.org/T355141