Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data wiring for wikitext template #4559

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Data wiring for wikitext template #4559

merged 9 commits into from
Apr 29, 2024

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Mar 27, 2024

Pending discussion:

  1. Should we send data only limited to Patroller Tasks?
  2. Use a better InvokeSource instead of sending isFromDiff everywhere? e.g. FROM_DIFF_TO_TALK_REPLY("fromDiffToTalkReply")

Bug: T359891

@cooltey cooltey added the HOLD Will review as soon as other more pressing PRs are merged/released. label Mar 27, 2024
@cooltey cooltey added Ready to merge PR passed design signoff and ready to be merged. and removed HOLD Will review as soon as other more pressing PRs are merged/released. labels Apr 25, 2024
@dbrant dbrant merged commit e713f7a into main Apr 29, 2024
1 check passed
@dbrant dbrant deleted the wikitext-template-data-wiring branch April 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
2 participants
@cooltey @dbrant