Google Pay integration.

[dbrant]

https://phabricator.wikimedia.org/T362698

[cooltey]

Would it be safer if we handle the null-safey check for donationConfig?

donationConfig?.let {
} ?: run {
    uiState.value = Resouce.Error("...")
}

[dbrant]

I'm actually not sure this would be safer... If donationConfig is null, it will throw a NullPointerException, which will be caught by the CoroutineExceptionHandler at the top, and will automatically provide a Resource.Error.

[cooltey]

Two questions:

1. When I changed the country code to TW (Taiwan), it showed the currency correctly, but it did not show the suggested amounts, is that expected?

2. It looks like the input field allows the user to add multiple zeros to the beginning of the amount, and it does not affect the final amount. Just wonder if we need to remove the unnecessary zero automatically.

3. When processing the payment, the activity title still showed the "Select amount" title with an empty content. Do we need to change the activity title to "Processing payment" or other proper title?

[dbrant]

@cooltey Excellent observations!

1. When I changed the country code to TW (Taiwan), it showed the currency correctly, but it did not show the suggested amounts, is that expected?

This actually might be a bug in the fundraising API -- it's not giving us the preset amounts for the TWD currency.
I'll make a note for the FR-tech team, and I updated the PR to bounce out of the GPay workflow (fall back to the browser) if the currency presets are not available. Thanks!

2. It looks like the input field allows the user to add multiple zeros to the beginning of the amount, and it does not affect the final amount. Just wonder if we need to remove the unnecessary zero automatically.

Ehhh I think that's an acceptable behavior. As long as the final amount is parsed correctly, why not let people enter 000001 when they really mean 1.

3. When processing the payment, the activity title still showed the "Select amount" title with an empty content. Do we need to change the activity title to "Processing payment" or other proper title?

¯\_(ツ)_/¯ this is how it was designed, and it's probably perfectly good for a first iteration. We will surely make refinements as we go along, and I'll make an additional note to discuss this step at the next prioritization.

[cooltey]

@cooltey Excellent observations!

1. When I changed the country code to TW (Taiwan), it showed the currency correctly, but it did not show the suggested amounts, is that expected?

This actually might be a bug in the fundraising API -- it's not giving us the preset amounts for the TWD currency. I'll make a note for the FR-tech team, and I updated the PR to bounce out of the GPay workflow (fall back to the browser) if the currency presets are not available. Thanks!

Great! Thanks!

2. It looks like the input field allows the user to add multiple zeros to the beginning of the amount, and it does not affect the final amount. Just wonder if we need to remove the unnecessary zero automatically.

Ehhh I think that's an acceptable behavior. As long as the final amount is parsed correctly, why not let people enter 000001 when they really mean 1.

That makes sense to me.

3. When processing the payment, the activity title still showed the "Select amount" title with an empty content. Do we need to change the activity title to "Processing payment" or other proper title?

¯_(ツ)_/¯ this is how it was designed, and it's probably perfectly good for a first iteration. We will surely make refinements as we go along, and I'll make an additional note to discuss this step at the next prioritization.

Got it!

---

I have one final question before merging:

From the article donate campaign dialog, when the user selects "Donate now", the GPay bottomsheet pops up. If the user accidentally closes the bottomsheet by tapping on the dimmed side, the entire donation flow will still be considered as "Completed".

Do we need to update the preference logic to make sure the user clicks one of the options in the GPay bottomsheet instead of saving the preference when tapping on the the dialog "Donate now"?