Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for previewing Talk pages that don't exist yet. #4631

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Apr 30, 2024

This is a workaround for our Preview endpoint, which returns an error if the target page doesn't exist yet.
We will now (silently) check if a Talk page exists while the user is typing a message, then call the Preview endpoint using the Main Page of the wiki, which produces acceptable results.

https://phabricator.wikimedia.org/T363781

@dbrant dbrant added Minor Minor stuff High Priority Priority code review needed labels Apr 30, 2024
@cooltey cooltey merged commit b2cd817 into main Apr 30, 2024
1 check passed
@cooltey cooltey deleted the previewNewPage branch April 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Priority code review needed Minor Minor stuff
2 participants