Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: do not add additional language variants to the langlinks if the list is empty #4639

Merged
merged 3 commits into from
May 4, 2024
Merged

Fix: do not add additional language variants to the langlinks if the list is empty #4639

merged 3 commits into from
May 4, 2024

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented May 3, 2024

This PR also converts the java test file to Kotlin, so we can remove @JvmStatic from the code.
Bug: T364059

@cooltey cooltey added Minor Minor stuff Ready to merge PR passed design signoff and ready to be merged. labels May 3, 2024
@dbrant dbrant merged commit 6e82d8f into main May 4, 2024
1 check passed
@dbrant dbrant deleted the fix-lang-variants-issue branch May 4, 2024 07:41
@cooltey cooltey mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
Minor Minor stuff Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
2 participants
@cooltey @dbrant