Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: the app should hide the empty card if the content is not empty #4647

Merged
merged 2 commits into from
May 10, 2024
Merged

Fix: the app should hide the empty card if the content is not empty #4647

merged 2 commits into from
May 10, 2024

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented May 7, 2024

Steps to reproduce it:

  1. Go to UtcDate and +1 for the day
  2. Configure the feed content to show only the top read.
  3. See empty card, press the device Home button
  4. Go back to the feed.

Bug: T364356

@cooltey cooltey added Minor Minor stuff Ready to merge PR passed design signoff and ready to be merged. labels May 7, 2024
@dbrant dbrant merged commit 113b2d7 into main May 10, 2024
1 check passed
@dbrant dbrant deleted the fix-emptycard-visibility branch May 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
Minor Minor stuff Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
2 participants
@cooltey @dbrant