Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature branch] Prompt existing generic ZH variant users to select regional variant #4677

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[Feature branch] Prompt existing generic ZH variant users to select regional variant #4677

wants to merge 12 commits into from

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented May 16, 2024 •
edited

This PR moves the chineseLocaleToWikiLanguageCode function to AppLanguageLookUpTable and updates its logic to be:

  1. Region first: get region language code from locale.country if the script is either Hant or Hans, or the language tag starts with zh-.
  2. Change the default fallback language code from zh-hant to zh-tw.
  3. Update test cases for the changes.

This PR should be fine to be merged into the main, or we can keep this in this ranch as a feature branch.

Bug: T360585

@cooltey cooltey added the WIP Work in progress label May 16, 2024
@cooltey cooltey requested a review from dbrant as a code owner May 16, 2024 21:57
@cooltey cooltey changed the title Update Chinese locale to wiki language code function Update AppLanguageLookUpTable to reduce usage of generic Chinese language variants May 17, 2024
@cooltey cooltey removed the WIP Work in progress label May 17, 2024
@cooltey cooltey added the HOLD Will review as soon as other more pressing PRs are merged/released. label May 20, 2024
@cooltey cooltey changed the title Update AppLanguageLookUpTable to reduce usage of generic Chinese language variants [Feature branch] Prompt existing generic ZH variant users to select regional variant May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

Assignees
No one assigned
Labels
HOLD Will review as soon as other more pressing PRs are merged/released.
Milestone
No milestone
1 participant
@cooltey