Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image recs: insert into infobox only for English. #4679

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented May 17, 2024

For the logic that attempts to insert the image into an infobox, we are supposed to be restricting it only to English, because we only have hardcoded infobox names and parameters in English.
But it looks like we're incorrectly falling back to English, and detecting infoboxes implicitly, which can lead to undesirable cases: for example French Wikipedia also uses a template called Infobox, but the parameter names are different (e.g. légende instead of caption), so let's add add an explicit check.

https://phabricator.wikimedia.org/T365252

@dbrant dbrant added Minor Minor stuff High Priority Priority code review needed labels May 17, 2024
@dbrant dbrant requested a review from cooltey as a code owner May 17, 2024 13:22
@cooltey cooltey merged commit d6e1601 into main May 17, 2024
1 check passed
@cooltey cooltey deleted the imageRecsInfoboxLang branch May 17, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Priority code review needed Minor Minor stuff
2 participants