Image recs: insert into infobox only for English. #4679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the logic that attempts to insert the image into an infobox, we are supposed to be restricting it only to English, because we only have hardcoded infobox names and parameters in English.
But it looks like we're incorrectly falling back to English, and detecting infoboxes implicitly, which can lead to undesirable cases: for example French Wikipedia also uses a template called
Infobox
, but the parameter names are different (e.g.légende
instead ofcaption
), so let's add add an explicit check.https://phabricator.wikimedia.org/T365252