Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPay: Fix setting language for currency NumberFormat. #4680

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented May 17, 2024

For the NumberFormat of the currency, we were unnecessarily giving it the current app language, which might be a language or variant that's unsupported by the NumberFormat system. Instead, we can simply initialize it with the default Locale, which picks up the current language of the device.

https://phabricator.wikimedia.org/T365278

@dbrant dbrant added Minor Minor stuff High Priority Priority code review needed labels May 17, 2024
@dbrant dbrant requested a review from cooltey as a code owner May 17, 2024 16:52
@cooltey cooltey merged commit 7faaa1e into main May 17, 2024
2 checks passed
@cooltey cooltey deleted the gPayFix1 branch May 17, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Priority code review needed Minor Minor stuff
2 participants