Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily load Read More items. #4690

Merged
merged 12 commits into from
May 23, 2024
Merged

Lazily load Read More items. #4690

merged 12 commits into from
May 23, 2024

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented May 22, 2024

Since PCS now allows us to load Read More items lazily, let's plug into that functionality.
This saves an entire API call when browsing any article, and only loads Read More items if the user scrolls all the way to the bottom.

https://phabricator.wikimedia.org/T353188

@dbrant dbrant requested a review from cooltey as a code owner May 22, 2024 11:40
@dbrant dbrant added the Ready to merge PR passed design signoff and ready to be merged. label May 22, 2024
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrant
Copy link
Member Author

dbrant commented May 23, 2024

I notice the read more does not work correctly for zhwiki and jawiki, which seems like an encoded issue.

@cooltey Well that's annoying, and a good catch. I definitely thought this was tested with non-ascii page titles.
It's definitely an issue on the PCS side (I made a task), and will be fixed there, independent of this PR.

@cooltey cooltey merged commit 49fe32d into main May 23, 2024
1 check passed
@cooltey cooltey deleted the readMoreLazyLoad branch May 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge PR passed design signoff and ready to be merged.
2 participants