Fix obscure login issue. #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I829832b37650440c11e4685131b812409f06b985
sharvaniharan
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we add up all the evidence that we have gathered so far, there is only one code path that could lead to the
logintokenbeing null in the login API call:The issue is not related to 2FA per se, but rather has to do with how we display and bind to the entry field for the 2FA token. For some reason, the text field for entering the 2FA code was being bound as an
EditText, instead of aTextInputLayoutas it's supposed to be. This may be producing unexpected behavior (on some devices / platforms) when we try to read the string value from the field.NOTE: We still need to test whether actual 2FA is still working after this patch.