Make BundleSign/BundleAuthSign return the root CA as well #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the BundleSign/BundleAuthSign API to return the root CA provided in the bundle response as well.
|
From my high level understanding of the code the change looks good, but I'll defer to @b4ldr for the final +1 :) |
|
looks good to me, i have also asked @lollipopman to take a look at this but if you need to unblock please feel free to merge and we can address any comments from jesse in a follow up |
lollipopman
reviewed
Jan 26, 2022
Thanks for taking a look. I tried to address your point in #5 |
looks good, approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the BundleSign/BundleAuthSign API to return the root CA
provided in the bundle response as well.
https://phabricator.wikimedia.org/T299906