Remove trimming from StringValue expert #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return null; | ||
| } | ||
| return value; | ||
| return this._newValue !== false ? this._newValue : this.$input.val(); |
There was a problem hiding this comment.
can be changed to equality by flipping - makes it easier to read
|
The commit message does not seem to match the code change. It removes the returning of null when empty string. |
|
You are absolutely right, that's not trimming, it's checking for white-space only. @addshore: We still wanna do this, right? |
|
@brightbyte What do you think about this? It's not trimming, it's checking for whitespace-only. |
|
probably up to @lydiapintscher |
|
I think we should remove white spaces at the beginning and the end. I can't think of a good case where this is useful compared to the pain of removing them when they shouldn't be there but are saved by Wikibase. Where and how it is done I don't have an opinion on. |
Turned !== around since it's a little bit easier to read.
thiemowmde
added a commit
that referenced
this pull request
Feb 18, 2014
This really, really doesn't belong here. Raw should be raw and not care about the meaning of specific characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.