common: Enforce no-shadow (#305)

Fixes #304
wikimedia · Jun 24, 2020 · ec2e954 · ec2e954
1 parent 438d184
commit ec2e954
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/common.json b/common.json
@@ -69,6 +69,7 @@
 		"no-script-url": "error",
 		"no-self-compare": "error",
 		"no-sequences": "error",
+		"no-shadow": "error",
 		"no-shadow-restricted-names": "error",
 		"no-tabs": [ "error", { "allowIndentationTabs": true } ],
 		"no-throw-literal": "error",

diff --git a/test/fixtures/common/invalid.js b/test/fixtures/common/invalid.js
@@ -2,6 +2,7 @@
 var APP;
 // eslint-disable-next-line wrap-iife
 ( function ( global ) {
+	// eslint-disable-next-line no-shadow
 	var APP;
 	// eslint-disable-next-line one-var
 	var upHere = function ( yArg ) {
@@ -76,7 +77,7 @@ var APP;
 			var e = items.event;
 			try {
 				return APP.loop( items );
-			} catch ( e ) {
+			} catch ( err ) {
 			}
 			return e;
 		}