Add Phan static checking #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSem
force-pushed
the
phan
branch
2 times, most recently
from
951a318
to
05370d6
Compare
MaxSem
added
Ready for review
MusikAnimal
requested changes
Apr 16, 2019
The tests produce too much noise for now so not enabling them in CI, however this commit includes a start of fixing.
|
Done. |
MusikAnimal
requested changes
Apr 18, 2019
| @@ -22,16 +22,18 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^7.2", | |||
| "ext-ast": "*", | |||
There was a problem hiding this comment.
This should be under require-dev, no? Also need to run composer update to make the lock file in sync
|
Phan is now in the repo, but not part of the test suite yet as there are many things still to fix |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests produce too much noise for now so not enabling them in CI,
however this commit includes a start of fixing.