Merge pull request #96 from wikimedia/fix_test

Fix tests for new preq retry defaults
wikimedia · Jan 25, 2019 · d432128 · d432128
2 parents 4c919a1 + daa0afa
commit d432128
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,7 @@
 language: node_js
 node_js:
-    - "4"
     - "6"
+    - "10"
     - "node"
 
 sudo: false

diff --git a/test/handlerTemplate/general.js b/test/handlerTemplate/general.js
@@ -116,7 +116,10 @@ describe('Handler Template', function() {
         var api = nock('http://mocked_domain_for_tests.com')
         .get('/TestTitle').reply(500, 'SERVER_ERROR', { 'Content-Type': 'text/plain' });
 
-        return preq.get({ uri: server.hostPort + '/service/return_if_test/TestTitle' })
+        return preq.get({
+            uri: server.hostPort + '/service/return_if_test/TestTitle',
+            retries: 0
+        })
         .then(function () {
             throw new Error('Error should be thrown');
         }, function(e) {

diff --git a/test/handlerTemplate/test_config.yaml b/test/handlerTemplate/test_config.yaml
@@ -36,6 +36,7 @@ spec_root: &spec_root
           - get_from_api:
               request:
                 uri: http://mocked_domain_for_tests.com/{title}
+                retries: 0
               return_if:
                 status: '2xx'
               catch: