Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for new preq retry defaults #96

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Fix tests for new preq retry defaults #96

merged 2 commits into from
Jan 25, 2019

Conversation

Pchelolo
Copy link
Contributor

After 0.5.7 the preq retrie semantics was fixed, while these tests relied on nock, so the fixed retry semantics has broken them.

cc @wikimedia/services

@coveralls
Copy link

coveralls commented Jan 24, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 91.925% when pulling daa0afa on fix_test into 4c919a1 on master.

@Pchelolo
Copy link
Contributor Author

Self-merge, trivial

@Pchelolo Pchelolo merged commit d432128 into master Jan 25, 2019
@Pchelolo Pchelolo mentioned this pull request Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pchelolo @coveralls