or-OdiScript input method. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone please take a look at this and add this? |
|
There are small issues. Please fix it and it should be ready: [L19:C37] W044: Bad or unnecessary escaping. [L20:C31] W044: Bad or unnecessary escaping. [L25:C17] W044: Bad or unnecessary escaping. [L38:C32] W044: Bad or unnecessary escaping. |
|
@psubhashish Can you fix above error and resubmit pull request? |
|
Can you remove these four and submit. Manoj is not available at this moment and there are more changes to be made soon by another contributor as he has found out many new needs. |
|
I'm not sure I can edit other's pull request. |
psubhashish
added a commit
to psubhashish/jquery.ime
that referenced
this pull request
Dec 11, 2015
As wikimedia#403 was not getting pushed and this is discussed at https://phabricator.wikimedia.org/T120634.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Requesting to add this input method to the 'or' rules.
Community discussion and consensus: https://goo.gl/TbonxO and http://goo.gl/l39acO
Also, please refer to the following discussion: #402
Thank you.