adding Fon language method #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikm
reviewed
May 19, 2018
rules/fon/fon-alt.js
Outdated
| name: 'fon-alt', | ||
| description: 'fon input keyboard', | ||
| date: '2018-05-18', | ||
| URL: 'http://github.com/wikimedia/jquery.ime', |
|
It would be nice to have tests for this input method. See: https://github.com/wikimedia/jquery.ime/tree/master/test You can follow some existing tests. |
santhoshtr
reviewed
May 19, 2018
rules/fon/fon-alt.js
Outdated
| license: 'GPLv3', | ||
| version: '1.0', | ||
| patterns: [ | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
please fix these merge conflict markers
There was a problem hiding this comment.
I already fixed this with @Mahuton on his laptop. He just needs to upload the new version :)
amire80
approved these changes
May 19, 2018
Closed
santhoshtr
reviewed
May 19, 2018
| @@ -4127,5 +4127,17 @@ var palochkaVariants = { | |||
| { input: [ 'v', [ '1', true ], 'i', 'T', 'U' ], output: 'វិទូ', description: 'ZWNJ (savant): v AltGr-1 iTU -> វិទូ' }, | |||
| { input: [ 'v', [ '`', true ], 'i', 'T', 'U' ], output: 'វិទូ', description: 'ZWJ (savant): v AltGr-` iTU -> វិទូ' } | |||
| ] | |||
| }, | |||
| { | |||
| description: 'fon alt test', | |||
There was a problem hiding this comment.
I see that you renamed the input method to fon tilde, should not we change this description too?
santhoshtr
reviewed
May 19, 2018
| { input: '~O', output: 'Ɔ', description: 'fon ~O -> Ɔ' }, | ||
| { input: '~o', output: 'ɔ', description: 'fon ~o -> ɔ' } | ||
| ], | ||
| inputmethod: 'fonTilde' |
There was a problem hiding this comment.
This should be the id of the input method fon-tilde in our case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.