Assign lang upon the creation of the testing element #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue 5. Firefox appears to have more fine-grained control on font configuration, which makes it return surprisng values ini non-English locales. Before this change the default font in the test suite and in the actual element would be different if the OS locale wasn't English. Hence, it's better to initialize the lang before initializing tests and webfonts.
| @@ -33,10 +34,10 @@ | |||
| if ( defaultFonts !== "" ) { | |||
| expectedResetFontFamilyList = | |||
| fontFamilyList( defaultFonts ).concat( expectedResetFontFamilyList ); | |||
| console.log( expectedResetFontFamilyList ); | |||
santhoshtr
added a commit
that referenced
this pull request
Nov 21, 2012
Assign lang upon the creation of the testing element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 5. Firefox appears to have more fine-grained control on
font configuration, which makes it return surprisng values in non-English
locales. Before this change the default font in the test suite and in
the actual element would be different if the OS locale wasn't English.
Hence, it's better to initialize the lang before initializing
tests and webfonts.