Skip to content

Commit

Permalink
Use display: inline-block instead of unicode-bidi
Browse files Browse the repository at this point in the history
On I16a701f3b962b5e7f63554be2f28888a938548b0 we incorporated
unicode-bidi: embed; instead isolate but it caused regression on
* https://fa.wikipedia.org/?oldid=15565588
* https://fa.wikipedia.org/?oldid=15552160
where references ([۱]) comes before number with Persian digits.

Using unicode-bidi: isolate; is the clean solution for fixing this
however due to Firefox bug https://bugzilla.mozilla.org/1185987
it is not going to fix the regression on Firefox so using
display: inline-block; in hope to get same effect with Chrome
on unicode-bidi: isolate; but also support IE and older browsers.

Change-Id: I1d62c1fb282acc72ab20d71cc8cd21e3e1d71493
  • Loading branch information
ebraminio authored and amire80 committed Aug 2, 2015
1 parent 70745da commit e9c1521
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion modules/ext.cite.styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@

/* Make sure the brackets and the numbers aren't jumbled after LTR words in RTL wikis */
sup.reference {
unicode-bidi: embed;
/* Ideally unicode-bidi: isolate should be used here,
however due Firefox bug https://bugzilla.mozilla.org/1185987
we use inline-block to replicate the effect */
display: inline-block;
}

/* Highlight clicked reference in blue to help navigation */
Expand Down

0 comments on commit e9c1521

Please sign in to comment.