Merge pull request #342 from wikimedia/no_cache_default

Switches default config to use no cache so pylru is not required.
wikimedia · Apr 28, 2020 · 6ba4499 · 6ba4499
2 parents fb4301e + 591eabd
commit 6ba4499
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/config/00-main.yaml b/config/00-main.yaml
@@ -14,6 +14,8 @@ ores:
 
 # Caching options
 score_caches:
+  no_cache:
+    class: ores.score_caches.Empty
   memory_lru:
     class: ores.score_caches.LRU
     size: 1024
@@ -55,7 +57,7 @@ metrics_collectors:
 scoring_systems:
   defaults:
     metrics_collector: local_logging
-    score_cache: memory_lru
+    score_cache: no_cache
     scoring_contexts:
       - testwiki
     timeout: 15 # seconds

diff --git a/ores/score_caches/empty.py b/ores/score_caches/empty.py
@@ -8,3 +8,7 @@ def lookup(self, *args, **kwargs):
 
     def store(self, *args, **kwargs):
         return None
+
+    @classmethod
+    def from_config(cls, config, name, section_key="score_caches"):
+        return cls()