Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit and reorganize desktop test cases #174

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Audit and reorganize desktop test cases #174

merged 4 commits into from
Mar 14, 2023

Conversation

bernardwang
Copy link
Collaborator

@bernardwang bernardwang commented Mar 8, 2023 •
edited
Loading

Summary

These changes reduce the number of cases from 136 to 118 while increasing test coverage

  • Reorganize and rename tests based off new categories, 'Pages', 'Layout', 'TOC', 'Sticky header', 'Search', 'Dropdowns', 'Legacy Vector'
  • Reduce number of images by restricting viewports for certain cases (i.e. sticky header only on desktop and larger)
  • Removes unnecessary/duplicate cases

nicholasray
nicholasray reviewed Mar 13, 2023
View reviewed changes
configDesktop.js Outdated Show resolved Hide resolved
@nicholasray
Copy link
Contributor

@bernardwang Thank you! This looks great! 👍

@nicholasray nicholasray merged commit adebb1b into main Mar 14, 2023
@nicholasray nicholasray deleted the bernard/reorganize-cases branch March 14, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasray nicholasray nicholasray left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@bernardwang @nicholasray