Add WikiLambda extension and tests #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was triggering lint error
montehurd
approved these changes
Jul 26, 2023
montehurd
reviewed
Jul 26, 2023
configWikiLambda.js
Outdated
| onBeforeScript: 'puppet/onBefore.js', | ||
| onReadyScript: 'puppet/onReady.js', | ||
| scenarios, | ||
| paths: utils.makePaths( 'desktop' ), |
There was a problem hiding this comment.
i might be wrong, but i think 'desktop' should be 'wikilambda' here so its folders in "reports" would end in 'wikilambda', for example
reports/reference-screenshots-wikilambda
reports/test-screenshots-wikilambda
There was a problem hiding this comment.
Monte is right. This is the folder it outputs too, so as written this would conflict with the desktop job.
|
Done. Thanks for spotting that. |
montehurd
approved these changes
Jul 27, 2023
|
After this change my Docker instance is read only and tests are failing in other projects. Is this expected behaviour or is there a bug in my install? If this is expected behaviour, perhaps it should use its own Docker instance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure the change I made to Dockerfile.mediawiki is the best way to achieve what I want. Happy to hear other suggestions.