-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WikiLambda extension and tests #192
Conversation
Was triggering lint error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for delayed review. Seems to work on my machine
configWikiLambda.js
Outdated
onBeforeScript: 'puppet/onBefore.js', | ||
onReadyScript: 'puppet/onReady.js', | ||
scenarios, | ||
paths: utils.makePaths( 'desktop' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i might be wrong, but i think 'desktop' should be 'wikilambda' here so its folders in "reports" would end in 'wikilambda', for example
reports/reference-screenshots-wikilambda
reports/test-screenshots-wikilambda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monte is right. This is the folder it outputs too, so as written this would conflict with the desktop job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
Done. Thanks for spotting that. |
After this change my Docker instance is read only and tests are failing in other projects. Is this expected behaviour or is there a bug in my install? If this is expected behaviour, perhaps it should use its own Docker instance? |
I am not sure the change I made to Dockerfile.mediawiki is the best way to achieve what I want. Happy to hear other suggestions.