Remove prefers-reduced-motion emulation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasray
force-pushed
the
remove-prefers-reduced-motion
branch
from
6f593d2
to
8f6f074
Compare
|
On the plus side.. we did a good thing for a11y! :D |
Unfortunately, the `transition-duration` in Ie1c6c1ba7263c232d874263fdae7427a5ec489f6 is causing elements to behave in an unpredictable manner. Removing the `prefers-reduced-motion` is now more stable/predictable than using it. Also, wait until next frame in `fastForwardAnimations`. Note there is still some flakiness with the visibility of the mobile sidebar that needs to be sorted out but this should help with the other random stuff.
nicholasray
force-pushed
the
remove-prefers-reduced-motion
branch
from
8f6f074
to
703335a
Compare
|
Hoping this helps with the randomness thats happening and if not we can revert it. I'm still noticing failures on the mobile site with the sidebar now showing sometimes that I need to look into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the
transition-durationinIe1c6c1ba7263c232d874263fdae7427a5ec489f6 is causing elements to behave in an
unpredictable manner. Removing the
prefers-reduced-motionis now morestable/predictable than using it.