Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config.js to configDesktop.js and fix linting errors #40

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Rename config.js to configDesktop.js and fix linting errors #40

merged 1 commit into from
Jun 10, 2022

Conversation

nicholasray
Copy link
Contributor

  • Rename config.js to follow the conventions set by other configs.
  • Revises reference and screenshot desktop folder names as well
  • Edit tsconfig to check all config files
  • Fix configEcho linting errors as a result of the preceding point

@nicholasray nicholasray force-pushed the rename-config.js branch 2 times, most recently from 9760be6 to 0e47136 Compare June 10, 2022 21:35
Rename config.js to configDesktop.js and fix linting errors
c69842e 
* Rename config.js to follow the conventions set by other configs.
* Revises reference and screenshot desktop folder names as well
* Edit tsconfig to check all config files
* Fix configEcho linting errors as a result of the preceding point
* Change configMobile test-screenshot-location to `test-screenshots-mobile` to
	follow conventions
@nicholasray nicholasray merged commit 4efea3e into main Jun 10, 2022
@nicholasray nicholasray deleted the rename-config.js branch June 10, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@nicholasray