Use unicode escapes for ASCII control characters. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N3 does not support many c-style escape sequences like \a. Bug: https://phabricator.wikimedia.org/T145757
|
@smalyshev please have a look |
smalyshev
reviewed
Sep 15, 2016
| "\x07" => '\u0007', | ||
| "\x08" => '\u0008', | ||
| "\x09" => '\u0009', | ||
| "\x0A" => '\u000A', |
There was a problem hiding this comment.
Why we have \x0A here if we already escaped it with addcslases?
There was a problem hiding this comment.
I wonder if we shouldn't use one function here instead of two. Escaping is called tens of millions of times when generating dump.
| // String escapes. Note that the N3 spec is more restrictive than the Turtle and TR | ||
| // specifications, see <https://www.w3.org/TeamSubmission/n3/#escaping> | ||
| // and <https://www.w3.org/TR/turtle/#string> | ||
| // and <https://www.w3.org/TR/n-triples/#grammar-production-literal>. |
There was a problem hiding this comment.
This says: ECHAR ::= '' [tbnrf"']
So there are more acceptable escapes than r. n and t - at least b and f also supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N3 does not support many c-style escape sequences like \a.
Bug: https://phabricator.wikimedia.org/T145757