Merge pull request #101 from wikimedia/content-length

Strip inappropriate content-length response headers
wikimedia · Dec 31, 2014 · c075063 · c075063
2 parents 484a46a + 419362a
commit c075063
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/server.js b/lib/server.js
@@ -82,6 +82,14 @@ function handleResponse (opts, newReq, resp, response) {
             resp.writeHead(response.status, '', response.headers);
             resp.end(body);
         } else {
+            if (response.headers['content-length']) {
+                opts.log('warn/response/content-length', {
+                    req: newReq,
+                    res: response,
+                    reason: new Error('Invalid content-length')
+                });
+                delete response.headers['content-length'];
+            }
             resp.writeHead(response.status, '', response.headers);
             resp.end();
         }

diff --git a/test/features/pagecontent/pagecontent.js b/test/features/pagecontent/pagecontent.js
@@ -40,7 +40,7 @@ module.exports = function (config) {
             });
         });
         it('should create a new html revision using proxy handler with id 624484444', function() {
-            this.timeout(40000);
+            this.timeout(20000);
             return preq.put({
                 uri: config.baseURL + '/test/Foo/wikitext/624484444',
                 headers: { 'content-type': 'text/html' },