Strip inappropriate content-length response headers #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ module.exports = function (config) { | |||
| }); | |||
| }); | |||
| it('should create a new html revision using proxy handler with id 624484444', function() { | |||
| this.timeout(40000); | |||
| this.timeout(20000); | |||
There was a problem hiding this comment.
I changed this to 40s a while ago to try to work around this problem.
| @@ -82,6 +82,10 @@ function handleResponse (opts, newReq, resp, response) { | |||
| resp.writeHead(response.status, '', response.headers); | |||
| resp.end(body); | |||
| } else { | |||
| if (response.headers && response.headers['content-length']) { | |||
There was a problem hiding this comment.
I think you can omit the check for response.headers, as we ensure that those are present in line 28.
gwicke
added a commit
that referenced
this pull request
Dec 31, 2014
Strip inappropriate content-length response headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been the source of many a failed test when PUTting to /v1/en.wikipedia.test.local/test/Foo/wikitext/624484444.