Change top editors endpoints docs to reflect change in anonymous users #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pchelolo
reviewed
Oct 30, 2018
| @@ -1109,7 +1109,7 @@ paths: | |||
| 100 editors by edits count. You can filter by editor-type (all-editor-types, | |||
| anonymous, group-bot, name-bot, user) or page-type (all-page-types, content or | |||
| non-content). The user_text returned is either the mediawiki user_text if the user is | |||
| registered, or "Anonymous Editor" if user is anonymous. | |||
| registered, or null if user is anonymous. | |||
There was a problem hiding this comment.
Technically that's backward-incompatible, do we care?
There was a problem hiding this comment.
It's not a problem. The endpoint is super young and only used by Wikistats 2, which already handles this issue.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this gerrit change https://gerrit.wikimedia.org/r/#/c/analytics/aqs/+/468927/ the top editors endpoints will be returning null instead of "Anonymous Editor". This patch just updates the docs for those two endpoints.
cc @jobar