Revision suppression / deletion detection #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever information about a revision is being retrieved (either from storage or by querying MW's API), its restrictions are now checked. If any of the *hidden fields are set, access is automatically denied to the caller.
|
Rebased onto master |
Merged
If a specific revision is passed in, a second, parallel request is made to the page_revisions module to determine whether the sought revision is accessible. In case it is restricted, access in denied to the user. Note that the content itself is fetched and stored regardless of access restrictions.
d00rman
changed the title
| * @throws rbUtil.httpError if access to the revision should be denied | ||
| */ | ||
| PRS.prototype._checkRevReturn = function(res) { | ||
| var item = res && res.body && Array.isArray(res.body.items) && res.body.items[0]; |
There was a problem hiding this comment.
I think the table storage API guarantees that a successful reply includes an items array, so we should be able to only check for its length.
gwicke
added a commit
that referenced
this pull request
Feb 13, 2015
Revision suppression / deletion detection
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build on #169 and provides the mechanism needed to deny access to revisions with restrictions. It is enforced both when requesting info about a specific revision (with or without providing a title), as well as its contents.
If a specific revision is passed in, a second, parallel request is made to the page_revisions module to determine whether the sought revision is accessible. In case it is restricted, access in denied to the user. Note that the content itself is fetched and stored regardless of access restrictions.