Implement and test the transform API as specced #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular functions are easier to reason about.
- First pass for the transform API as specced - Generate data needed for selser on demand by using the top-level request API - Simpler and more robust transform tests. The request/response structure is a nice idea to keep the data out of the tests, but is fragile vs. changes in the exact output. With minimal requests and predicates on the responses the tests are both more readable and less likely to break on minor changes in Parsoid output. - Start testing selective html2wt conversion. This revealed a possible bug in the Parsoid v2 API: https://phabricator.wikimedia.org/T89411 For this reason, the selser test is currently disabled.
1 similar comment
Remove request/response pairs and associated loading logic.
| }); | ||
| } | ||
|
|
||
| return Promise.all([ get('html'), get('wikitext'), get('data-parsoid') ]) | ||
| .then(function () { | ||
| // Get the revision info just to make sure we have access |
There was a problem hiding this comment.
These things are resolved in #172 ;)
- Remove a stray debug print - Fix body extraction regexp - Re-enable content validation check
This is now handled in getFormat for each request, so we don't have to do this for the transform end points any more.
This makes the selser tests more robust, as it will continue to work even if there are minor changes in Parsoid HTML output.
d00rman
pushed a commit
that referenced
this pull request
Feb 14, 2015
Implement and test the transform API as specced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://phabricator.wikimedia.org/T75955