Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and test the transform API as specced #173

Merged
merged 16 commits into from
Feb 14, 2015
Merged

Implement and test the transform API as specced #173

merged 16 commits into from
Feb 14, 2015

Commits on Feb 12, 2015

  1. Cleanup: Don't use side-effects and in-place updates 

    Regular functions are easier to reason about.
    @gwicke
    gwicke committed Feb 12, 2015
    Configuration menu
    Copy the full SHA
    a0296cb View commit details
    Browse the repository at this point in the history

  2. Implement plain-post transform API 

    - First pass for the transform API as specced
- Generate data needed for selser on demand by using the top-level request API
- Simpler and more robust transform tests. The request/response structure is a
  nice idea to keep the data out of the tests, but is fragile vs. changes in
  the exact output. With minimal requests and predicates on the responses the
  tests are both more readable and less likely to break on minor changes in
  Parsoid output.
- Start testing selective html2wt conversion. This revealed a possible bug in
  the Parsoid v2 API: https://phabricator.wikimedia.org/T89411
  For this reason, the selser test is currently disabled.
    @gwicke
    gwicke committed Feb 12, 2015
    Configuration menu
    Copy the full SHA
    bcde0ab View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2015

  1. Fix & test wt2html transform

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    57c2eb3 View commit details
    Browse the repository at this point in the history

  2. Add test for html2html & some clean-up

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    4ebe2d5 View commit details
    Browse the repository at this point in the history

  3. Transform test clean-up 

    Remove request/response pairs and associated loading logic.
    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    ebc31e2 View commit details
    Browse the repository at this point in the history

  4. Handle and test bodyOnly flag when converting to HTML 

    Bug: T88319
    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    f48eceb View commit details
    Browse the repository at this point in the history

  5. Re-write test domain for parsoid requests

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    481e194 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'wikimedia/master'

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    8560726 View commit details
    Browse the repository at this point in the history

  7. Address some of Marko's comments 

    - Remove a stray debug print
- Fix body extraction regexp
- Re-enable content validation check
    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    ceb4a60 View commit details
    Browse the repository at this point in the history

  8. Add html2html test with bodyOnly flag

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    fd14000 View commit details
    Browse the repository at this point in the history

  9. De-tabify test file

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    71e33e4 View commit details
    Browse the repository at this point in the history

  10. Use assert.contentType in tests

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    b69c7e6 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'wikimedia/master'

    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    8cc6cea View commit details
    Browse the repository at this point in the history

  12. Skip the explicit revision access check 

    This is now handled in getFormat for each request, so we don't have to do this
for the transform end points any more.
    @gwicke
    gwicke committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    161f590 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2015

  1. Add a comment about local parsoid testing in the config

    @gwicke
    gwicke committed Feb 14, 2015
    Configuration menu
    Copy the full SHA
    f93c1ec View commit details
    Browse the repository at this point in the history

  2. Dynamically load Parsoid HTML 

    This makes the selser tests more robust, as it will continue to work even if
there are minor changes in Parsoid HTML output.
    @gwicke
    gwicke committed Feb 14, 2015
    Configuration menu
    Copy the full SHA
    22e1fc4 View commit details
    Browse the repository at this point in the history