Switch definitions to new storage #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d00rman
reviewed
Nov 7, 2017
v1/definition.yaml
Outdated
| @@ -85,7 +85,7 @@ paths: | |||
| # Set up a simple key-value bucket. | |||
| - init: | |||
| method: 'put' | |||
| uri: /{domain}/sys/key_value_old/term.definition | |||
| uri: /{domain}/sys/key_value/term.definition | |||
There was a problem hiding this comment.
For the schema-creation process of definitions, we added the -ng prefix which I think is good for compatibility. We should add it here as well.
Change-Id: I8b93aaa3891623edc39b93992c1d5dcbff6d7de4
Change-Id: I9bca6abdb36633c99d5cbd4918cc1f444e7d6334
Pchelolo
force-pushed
the
definition_new_storage
branch
from
2fd404d
to
ffbc73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think after we switch summary we don't need to make a proxy for the definitions.
Bug: T179420
cc @wikimedia/services