Fix failure if there's no content-type returned #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id5bf5c94dac06ec02a91137e3f0c002924d55301
|
Self-merge to deploy to beta cluster to allow testing of Page Previews T182639 |
d00rman
reviewed
Dec 12, 2017
| @@ -47,7 +47,13 @@ function checkContentType(hyper, req, next, expectedContentType, responsePromise | |||
| return res; | |||
| } | |||
|
|
|||
| if (res.headers && res.headers['content-type'] !== expectedContentType) { | |||
| if (res.headers && res.headers === undefined) { | |||
There was a problem hiding this comment.
I fail to see how this will ever evaluate to true. If res.headers === undefined then res.headers will always yield a false outcome, which means that the outcome will always be false. I also fail to see the benefit of deleting the content-type key in this circumstance.
There was a problem hiding this comment.
Oh this is obviously a bug, it should read res.headers['content-type'] === undefined
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T182619
cc @wikimedia/services @berndsi @mdholloway