Normalize the logging messages for easier filtering in kibana #180
Conversation
The additional information has been moved to separate fields in logs, like this we can easily filter out mesages about worker deaths and filter a sequence of events that lead to the death of a particular worker. Bug: https://phabricator.wikimedia.org/T186761
lib/master.js
Outdated
| && this._firstWorkerStartupAttempts++ >= STARTUP_ATTEMPTS_LIMIT) { | ||
| // We tried to start the first worker 3 times, but never succeed. | ||
| // Give up. | ||
| this._logger.log('fatal/service-runner/master', |
There was a problem hiding this comment.
Would be good to have the exit code
|
LGTM modulo small nit |
|
Tagged and published as service-runner@2.5.1 |
|
That was fast! |
|
@Pchelolo I think you wanted to use {"name":"service-mobileapp-node","hostname":"box","pid":6131,"level":30,"message":"worker shutting down","worker_pid":6131,"levelPath":"info/service-runner/worker","msg":"worker shutting down","time":"2018-02-08T16:36:24.717Z","v":0} Also, it looks like the pid was already there: |
|
Oh holy hell I thought we've fixed the msg/message thing. Will fix. On the |
Changed one log message in our code to drop the pid from the message string since it is already included in the `pid` field. Changed the string also to start with lower case to be consistent with the change in wikimedia/service-runner#180. FWIW, updated the version in package.json. That is mostly for documentation purposes since we would get that update automatically anyways. Change-Id: I1406cfb479f0d689ed4b56b467dc5328a70d68a5
|
Then it's ok to keep the |
The additional information has been moved to separate fields in logs,
like this we can easily filter out mesages about worker deaths and
filter a sequence of events that lead to the death of a particular
worker.
Bug: https://phabricator.wikimedia.org/T186761
cc @wikimedia/services @berndsi @mdholloway