Add confirmation dialog when switching target lang with unsaved changes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
added
ready for review
samwilson
force-pushed
the
confirm-switch-T207199
branch
from
d49281a
to
8613a52
Compare
When a user switches the target language but has unsaved changes in the translation form, show a dialog box asking if they're sure they want to lose their work. Bug: https://phabricator.wikimedia.org/T207199
samwilson
force-pushed
the
confirm-switch-T207199
branch
from
8613a52
to
8685257
Compare
MusikAnimal
reviewed
Jan 18, 2019
| @@ -29,6 +29,8 @@ | |||
| "default-language": "Default language", | |||
| "source-lang-not-found": "Untranslated. Default: $1", | |||
| "source-to-target": "to", | |||
| "confirmation-to-switch-target-lang": "You are trying to change the translation language but you have unsaved translations. Changing the language will result in loss of any added translations. Please upload the translations to Commons or download the translated file before proceeding. Do you wish to continue?", | |||
| "confirm-change-target-lang": "Change language", | |||
There was a problem hiding this comment.
Why do we duplicate the translations in /i18n/ here in /public/assets/i18n?
There was a problem hiding this comment.
Could you use a symlink instead?
There was a problem hiding this comment.
No, becuase one of the copied dirs is node_modules/jquery.uls/i18n which doesn't exist in the repo.
MusikAnimal
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user switches the target language but has unsaved changes in
the translation form, show a dialog box asking if they're sure they
want to lose their work.
Bug: https://phabricator.wikimedia.org/T207199