Allow protocol relative URLs for the image #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
force-pushed
the
image-url
branch
3 times, most recently
from
b5291e9
to
bdf3c36
Compare
|
I'm fixing the Phan failure here by upgrading Phan, see #60. |
* Remove the imageUrl member variable, and pass the image around as a param as is done for other form variables etc. * Add 'https' to protocol-relative URLs, and also make the validation regex more lenient (even though there shouldn't be any need for it to be now the controller adds the prefix). Bug: T324740
|
Oh well, the Phan upgrade didn't fix it; have suppressed it for now. Will follow up later because we need to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both http and https are already allowed, and the actual validation is done based on hostname so there shouldn't be any issue with making this regex more lenient.
Bug: T324740