Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Commit

Permalink
Fix theme CSS regression.
Browse files Browse the repository at this point in the history
Noticed on `enwiki > Javascript`. The collapsed tables borders were gone when using sepia or dark themes.

Caused by using the '-p' webpack switch, which caused the CSS to be minified ( webpack-contrib/html-loader#65 (comment) ), which changed the order of CSS, which was important. Specifically, the `ThemeTransform` CSS needs to be 1st, as outlined here https://github.com/wikimedia/wikimedia-page-library/blob/master/src/transform/index.js#L3 and here #128 (comment)
  • Loading branch information
montehurd committed May 4, 2018
1 parent 66510c8 commit cb7be14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion webpack.config.babel.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const config = {
loader: 'style-loader',
options: { hmr: false }
},
use: [{ loader: 'css-loader' }, 'postcss-loader']
use: [{ loader: 'css-loader', options: { minimize: false } }, 'postcss-loader']
})
}
]
Expand Down

0 comments on commit cb7be14

Please sign in to comment.