How to turn off minification? #65

ccorcos · 2016-06-24T22:05:34Z

    htmlLoader: {
      minimize: false,
    },

doesnt seem to work

The text was updated successfully, but these errors were encountered:

ccorcos · 2016-06-24T22:08:55Z

These defaults are terrible:

https://github.com/webpack/html-loader/blob/master/index.js#L71-L88

<!DOCTYPE html> <html lang=en> <head> <meta charset=UTF-8> <title>Skeleton App</title> <meta name=viewport content="width=device-width,initial-scale=1"> </head> <body> <div id=root></div> <img src=<%=ROOT_URL%>/7d3f8da0eae1b0de9b3e8ef7ac4615b4.png /> <script type="text/javascript" src="<%=ROOT_URL%>/index-542e410e44a0f3d636e0.js"></script></body> </html>

ccorcos · 2016-06-24T23:52:23Z

I think it would be great if they were configurable but I cant figure out how to do that. Perhaps its a porblem with using it inside HtmlWebpackPlugin

toverux · 2016-06-30T10:56:51Z

I use it this way, and that works :

{ test: /\.html$/, loader: 'html?minimize=false', exclude: [root('src', 'index.html')] },

https://github.com/webpack/html-loader/blob/master/index.js#L68

And yes, I agree, these are very destructive defaults :/

ccorcos · 2016-06-30T17:42:21Z

hmm. the problem is I'm using it with the Webpack HTML Plugin...

toverux · 2016-06-30T18:40:06Z

Me too :) And the HtmlWebpackPlugin does not seem to cause any problem here, it's just html-loader's minimification, at least in my configuration (note that I also have excluded index.html in html-loader's configuration):

const BASE_CONFIG = {
    plugins: [
        new HtmlWebpackPlugin({ template: 'src/index.html' })
    ],

    module: {
        loaders: [
            { test: /\.html$/, loader: 'html?minimize=false', exclude: [root('src', 'index.html')] }
        ]
    }
};

imvetri · 2016-07-03T17:00:48Z

You can try the following? Please dont mind. i didnt try the code, I could guess this from the code
https://github.com/webpack/html-loader/blob/master/index.js#L68 difference.

htmlLoader:{"removeComments : false",
"removeCommentsFromCDATA : false",
"removeCDATASectionsFromCDATA : false",
"collapseWhitespace : false",
"conservativeCollapse : false",
"removeAttributeQuotes : false",
"useShortDoctype : false",
"keepClosingSlash : false",
"minifyJS : false",
"minifyCSS : false",
"removeScriptTypeAttributes : false",
"removeStyleTypeAttributes : false"}

imvetri · 2016-07-03T17:09:00Z

@ccorcos Can i request something? Could you share information on How you specifically opened the code difference at https://github.com/webpack/html-loader/issues/url ?

Above comment is my first comment on a open source 💃 yay. and i am curious how you were able to point at specific piece of code.

ccorcos · 2016-07-05T17:31:39Z

So I'm using the html webpack plugin like this:

      new HtmlWebpackPlugin({
        template: `!html!${config.html}`,
        inject: 'body',
      }),

It appears that adding any inline query params causes errors, and when I use something like...

    htmlLoader: {
      removeComments: false,
      removeCommentsFromCDATA: false,
      removeCDATASectionsFromCDATA: false,
      collapseWhitespace: false,
      conservativeCollapse: false,
      removeAttributeQuotes: false,
      useShortDoctype: false,
      keepClosingSlash: false,
      minifyJS: false,
      minifyCSS: false,
      removeScriptTypeAttributes: false,
      removeStyleTypeAttributes: false
    },

... it doesnt work either.

@imvetri When you are looking at code on github, click a line number and it it will get highlighted and change the url. You can also shift-click to another location to highlight a range.

jackyon · 2016-07-17T06:15:17Z

not working for me either, the html code still get compressed..
is there any solution for this issue?

imvetri · 2016-07-17T11:38:53Z

Can someone help me understand with this condition
https://github.com/webpack/html-loader/blob/master/index.js#L68

I suspect this line and it is taking program control inside the IF block all ways.

Hence minify=true is not working?

ccorcos · 2016-07-19T18:17:13Z

Whats going on is there are two configurations to effectively turn on minification. One is the htmlLoader field. so if you put htmlLoader: { minimize: false }, then that will override this.minimize which I believe is set when running webpack -p

abelokon · 2016-07-29T23:05:10Z

+1 same problem using HtmlWebpackPlugin - any updates?

ccorcos · 2016-07-29T23:13:29Z

I didnt figure anything out -- at then end of the day, it does work...

joshwiens · 2016-07-30T05:22:46Z

@abelokon There are a few "problems" mentioned here. The original was the defaults for html loader in regards to minification which has been changed. The second was effectively minifing twice.

Could you be a bit more specific to which issue you are referencing?

abelokon · 2016-07-30T06:39:20Z

@d3viant0ne As already mentioned I'm also using HtmlWebpackPlugin and trying figure out how to turn off the minification of my html files. Since the first snippet posted here didn't work for me either, I agreed.

eladchen · 2016-09-26T09:13:01Z

FYI: Looking at this commit @ index.js:19

It seems that there is an issue with how "configKey" is looked up. The config key is looked up using
hasOwnProperty( ... ) on 'context.options' - This will never yield true, as the key does exists, but on 'context.options.prototype'.

Edit:
To overcome this alleged issue, the only way to provide options, is to use the syntax suggested in the loaders query parameters docs.

In order to disable minimizing, use:

loaders: [ {
    test:   /\.html$/,
    loader: 'html-loader',
    query:  {
        minimize: false
    }
} ]

Please correct me if I'm wrong.

ghjagus · 2016-11-08T13:15:29Z

Is there a way that minimize the html string but keep case sensitive?Because i use PascalCase-style to name my components.

hemanth · 2017-03-09T13:56:42Z

Thanks for reporting, this is fixed in #116.

Noticed on `enwiki > Javascript`. The collapsed tables borders were gone when using sepia or dark themes. Caused by using the '-p' webpack switch, which caused the CSS to be minified ( webpack-contrib/html-loader#65 (comment) ), which changed the order of CSS, which was important. Specifically, the `ThemeTransform` CSS needs to be 1st, as outlined here https://github.com/wikimedia/wikimedia-page-library/blob/master/src/transform/index.js#L3 and here #128 (comment)

amirhosein993 · 2020-01-17T12:07:56Z

I use it this way, and that works :
{ test: /\.html$/, loader: 'html?minimize=false', exclude: [root('src', 'index.html')] },
https://github.com/webpack/html-loader/blob/master/index.js#L68

And yes, I agree, these are very destructive defaults :/

where to write this?
thanks

hemanth added the question label Sep 7, 2016

dbailo1988 mentioned this issue Mar 9, 2017

docs: improving docs for minimizing options in webpack config #116

Merged

9 tasks

hemanth closed this as completed Mar 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

How to turn off minification? #65

How to turn off minification? #65

ccorcos commented Jun 24, 2016

ccorcos commented Jun 24, 2016

ccorcos commented Jun 24, 2016

toverux commented Jun 30, 2016 •

edited

ccorcos commented Jun 30, 2016

toverux commented Jun 30, 2016 •

edited

imvetri commented Jul 3, 2016

imvetri commented Jul 3, 2016

ccorcos commented Jul 5, 2016

jackyon commented Jul 17, 2016

imvetri commented Jul 17, 2016

ccorcos commented Jul 19, 2016

abelokon commented Jul 29, 2016 •

edited

ccorcos commented Jul 29, 2016

joshwiens commented Jul 30, 2016

abelokon commented Jul 30, 2016

eladchen commented Sep 26, 2016 •

edited

ghjagus commented Nov 8, 2016

hemanth commented Mar 9, 2017

amirhosein993 commented Jan 17, 2020

How to turn off minification? #65

How to turn off minification? #65

Comments

ccorcos commented Jun 24, 2016

ccorcos commented Jun 24, 2016

ccorcos commented Jun 24, 2016

toverux commented Jun 30, 2016 • edited

ccorcos commented Jun 30, 2016

toverux commented Jun 30, 2016 • edited

imvetri commented Jul 3, 2016

imvetri commented Jul 3, 2016

ccorcos commented Jul 5, 2016

jackyon commented Jul 17, 2016

imvetri commented Jul 17, 2016

ccorcos commented Jul 19, 2016

abelokon commented Jul 29, 2016 • edited

ccorcos commented Jul 29, 2016

joshwiens commented Jul 30, 2016

abelokon commented Jul 30, 2016

eladchen commented Sep 26, 2016 • edited

ghjagus commented Nov 8, 2016

hemanth commented Mar 9, 2017

amirhosein993 commented Jan 17, 2020

toverux commented Jun 30, 2016 •

edited

toverux commented Jun 30, 2016 •

edited

abelokon commented Jul 29, 2016 •

edited

eladchen commented Sep 26, 2016 •

edited