Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

First pass at 'everything demo' of transforms on actual articles #164

Merged
merged 15 commits into from
Apr 24, 2019

Conversation

montehurd
Copy link
Collaborator

@montehurd montehurd commented Oct 31, 2018

https://phabricator.wikimedia.org/T172166

This first pass implements the following:

  • apply transforms to actual articles (lazy image loading not yet implemented)
  • use same article data files as theme demo
  • allow multiple articles to be viewed at once
  • allow quick-jump between articles being viewed
  • automatically re-apply transform selections to newly selected articles

It still needs to conform to our linting and documentation standards, which I'll chip away at.

@berndsi and I also discussed updates which will need to be made to support representation of PCS article data. Things we discussed:

  • a way to make articleRef support non-section loading (PCS delivers entire article, not sections - move index html and section html wrapping into articleRef?) and related changes to the demo html file
  • a way to exclude particular transforms from particular sources (for example, PCS already does certain transforms, MCS already relocates 1st paragraphs, etc...) (Will look at later)
  • what we could show above each article preview iframe to indicate what transforms were actually applied to that article (PCS for example wouldn't list any transforms it applies upstream) to make proofing expectations easier to confirm (Will look at later)

Other considerations:

  • should we eventually remove some of the old demo code? or only, say, all demos except the lazy image loading demos?

@montehurd montehurd added the WIP label Oct 31, 2018
@berndsi
Copy link
Contributor

berndsi commented Nov 6, 2018

@montehurd This looks great. Just one question: Is the order the transforms show up in the control in the same order as they should be invoked? If not I think that would be useful. Other than this question this looks great.

@montehurd montehurd removed the WIP label Apr 18, 2019
@montehurd montehurd requested a review from berndsi April 18, 2019 19:16
Copy link
Contributor

@berndsi berndsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much for your work on this!

@berndsi berndsi merged commit 03bbd8c into master Apr 24, 2019
@berndsi berndsi deleted the new/everything-demo branch April 24, 2019 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants