This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
Native Source Editor Component - Part 1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Minor bug fixes after testing
tonisevener
changed the title
tonisevener
requested review from
a team and
mazevedofs
and removed request for
a team
mazevedofs
reviewed
May 16, 2023
|
@mazevedofs hmm I'm not seeing those - which device or simulator are you using? |
@tonisevener I was testing on simulator, iPhone 14 Pro, 16.1 |
mazevedofs
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T331936
Notes
This PR sets up the initial source editor classes. It sets up the
WKSourceEditorViewController, which loads a view that contains a singleUITextViewas our editor. This PR also sets up all of the formatting toolbars and component-izes them to fit our new theming and font patterns.Note that I expect that some of the theming, icon, and font details will change once design has a pass at this. I tried to get this initial PR to look close enough to our current editor to not be distracting, so that I can move on with setting up the syntax highlighting formatters in the next PR.
Note that this PR is built off of #7, so that I could theme and test these views more thoroughly.