Add Native Source Editor - Part 1 #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
requested review from
bvibber,
a team and
staykids
and removed request for
a team and
bvibber
tonisevener
changed the title
I can reproduce this bug in |
tonisevener
changed the title
staykids
reviewed
May 8, 2023
| @@ -1853,6 +1854,7 @@ - (void)updateAppThemeIfNecessary { | |||
| if (self.theme != theme) { | |||
| [self applyTheme:theme]; | |||
| [self.settingsViewController loadSections]; | |||
| [self setWKAppEnvironmentThemeWithTheme: theme]; | |||
There was a problem hiding this comment.
Just a note for forthcoming PRs that we'd eventually need to also pass along the trait collection changes so the font scaling respects our design intents.
There was a problem hiding this comment.
Thanks - this is updated!
| func pageEditorDidCancelEditing(_ pageEditor: PageEditorViewController, navigateToURL: URL?) | ||
| } | ||
|
|
||
| class PageEditorViewController: UIViewController { |
There was a problem hiding this comment.
Should we mark this as final?
| // MARK: - WKSourceEditorViewControllerDelegate | ||
|
|
||
| extension PageEditorViewController: WKSourceEditorViewControllerDelegate { | ||
| func sourceEditorViewControllerDidTapFind(sourceEditorViewController: Components.WKSourceEditorViewController) { |
There was a problem hiding this comment.
The Components. namespace prefix is unneeded here.
…o source-editor-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T331936
Notes
This PR adds the native editor feature flag and implements the initial pieces of it within
PageEditorViewController. I also added a full source edit button inArticleViewController, so that we can test performance against a large set of wikitext as we build this. The entry point of this full source edit button is likely to change before release, though.Note I found a bug in the default automatic theme switching in this branch. Marking as draft while I look into that.
Test Steps